Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing: commit message #153

Open
iGormilhit opened this issue May 22, 2019 · 0 comments
Open

contributing: commit message #153

iGormilhit opened this issue May 22, 2019 · 0 comments

Comments

@iGormilhit
Copy link
Contributor

At RERO we've just noticed that there's still an old example of commit message in the CONTRIBUTING.rst file:

6. Commit your changes and push your branch to GitHub:

   .. code-block:: console

      $ git add .
      $ git commit -s
          -m "component: title without verbs"
          -m "* NEW Adds your new feature."
          -m "* FIX Fixes an existing issue."
          -m "* BETTER Improves and existing feature."
          -m "* Changes something that should not be visible in release notes."
      $ git push origin name-of-your-bugfix-or-feature

As far as I understand, commit message recommendations has changed: https://github.com/inveniosoftware/invenio/blob/master/CONTRIBUTING.rst#commit-messages

Should the cookiecutter template be updated accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant