-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Description
Context
As a community curator, I want to allow specific users/groups per request to be able to comment on a specific request. These users should not be able to change the status of the request or modify the record.
Requirements
- We need to be able to assign reviewers to a specific request.
- A reviewer can be either a user or a group.
- Once added, a reviewer can
- comment on a request
- to explore: indicate if they approve a request. In some contexts, e.g CERN institutional repository, the approval action leads to confusion because of the existence of the "Accept and publish"
Existing prototype
In the linked PRs, there is some prework done:
- New
reviewers
field added in the request jsonschema (missing to be added in the opensearch mappings) - The entity reference/resolution classes were duplicated to support array of entities. They should be merged or refactored to utilize the single entity reference classes.
- (This can be splitted in a separate issue) Evaluate if we need to store the
opiniated
review in a separate field ala GH.- If not, remove the field
lastOpiniatedReview
(name to be checked) - If yes, change the code to support a list of opiniated reviews in accordance with the reviewers
- If not, remove the field
Future Ideas/Discussions
- reviews: adding request reviewers base implementation #431 (comment)
- Add a notification for review
- Add role name in from of the user name in each comment ex:
User 1 (reviewer)
Tasks
- Config for disabling groups
- feature flag for entire feature
- UI/UX - Fix UI when no reviewer is selected
- Fix UI with larger names
- Add timeline event when reviewer added/removed
- Fix access for the reviewer after removed (TBD)
- Limit people who can add a reviewer (TBD)
- Add tests
Metadata
Metadata
Labels
No labels
Type
Projects
Status
To release 🤖