config: make community request type classes customizable

* Allows to customize community submissions and inclusion request type
  classes via the ``RDM_COMMUNITY_SUBMISSION_REQUEST_CLS`` and
  ``RDM_COMMUNITY_INCLUSION_REQUEST_CLS`` config variables.

Author: slint

invenio_rdm_records/config.py

@@ -26,6 +26,8 @@
 from invenio_rdm_records.services.components.verified import UserModerationHandler
 
 from . import tokens
+from .requests.community_inclusion import CommunityInclusion
+from .requests.community_submission import CommunitySubmission
 from .resources.serializers import DataCite43JSONSerializer
 from .services import facets
 from .services.config import lock_edit_published_files
@@ -124,8 +126,11 @@ def always_valid(identifier):
 # Record review requests
 #
 RDM_RECORDS_REVIEWS = [
-    "community-submission",
+    CommunitySubmission.type_id,
 ]
+"""List of review request types."""
+RDM_COMMUNITY_SUBMISSION_REQUEST_CLS = CommunitySubmission
+"""Request type for community submission requests."""
 
 #
 # Record files configuration
@@ -147,6 +152,8 @@ def always_valid(identifier):
 #
 RDM_COMMUNITY_REQUIRED_TO_PUBLISH = False
 """Enforces at least one community per record."""
+RDM_COMMUNITY_INCLUSION_REQUEST_CLS = CommunityInclusion
+"""Request type for record inclusion requests."""
 
 #
 # Search configuration

invenio_rdm_records/requests/community_inclusion.py

@@ -12,7 +12,6 @@
 from invenio_notifications.services.uow import NotificationOp
 from invenio_records_resources.services.uow import RecordIndexOp
 from invenio_requests.customizations import RequestType, actions
-from invenio_requests.errors import CannotExecuteActionError
 
 from invenio_rdm_records.notifications.builders import (
     CommunityInclusionAcceptNotificationBuilder,
@@ -68,7 +67,7 @@ def execute(self, identity, uow, **kwargs):
         parent_community = getattr(community, "parent", None)
         if (
             parent_community
-            and not str(parent_community.id) in record.parent.communities.ids
+            and str(parent_community.id) not in record.parent.communities.ids
         ):
             record.parent.communities.add(parent_community, request=self.request)
 
@@ -120,3 +119,15 @@ class CommunityInclusion(RequestType):
         "cancel": actions.CancelAction,
         "expire": actions.ExpireAction,
     }
+
+
+def get_request_type(app):
+    """Return the community inclusion request type from config.
+
+    This function is only used to register the request type via the
+    ``invenio_requests.types`` entrypoint, and allow to customize the request type
+    class via the ``RDM_COMMUNITY_INCLUSION_REQUEST_CLS`` application config.
+    """
+    if not app:
+        return
+    return app.config.get("RDM_COMMUNITY_INCLUSION_REQUEST_CLS", CommunityInclusion)

invenio_rdm_records/requests/community_submission.py

@@ -204,3 +204,15 @@ class CommunitySubmission(ReviewRequest):
         "cancel": CancelAction,
         "expire": ExpireAction,
     }
+
+
+def get_request_type(app):
+    """Return the community submission request type from config.
+
+    This function is only used to register the request type via the
+    ``invenio_requests.types`` entrypoint, and allow to customize the request type
+    class via the ``RDM_COMMUNITY_SUBMISSION_REQUEST_CLS`` application config.
+    """
+    if not app:
+        return
+    return app.config.get("RDM_COMMUNITY_SUBMISSION_REQUEST_CLS", CommunitySubmission)

setup.cfg

@@ -123,8 +123,8 @@ invenio_search.mappings =
 invenio_i18n.translations =
     invenio_rdm_records = invenio_rdm_records
 invenio_requests.types =
-    community_inclusion = invenio_rdm_records.requests:CommunityInclusion
-    community_submission = invenio_rdm_records.requests:CommunitySubmission
+    community_inclusion = invenio_rdm_records.requests.community_inclusion:get_request_type
+    community_submission = invenio_rdm_records.requests.community_submission:get_request_type
     user_access_request = invenio_rdm_records.requests:UserAccessRequest
     guest_access_request = invenio_rdm_records.requests:GuestAccessRequest
 invenio_requests.entity_resolvers =