deposit: fix global server errors in frontend

Author: zzacharo

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/api/DepositApiClient.js

@@ -7,6 +7,7 @@
 
 import axios from "axios";
 import _get from "lodash/get";
+import _isEmpty from "lodash/isEmpty";
 
 const BASE_HEADERS = {
   "json": { "Content-Type": "application/json" },
@@ -108,7 +109,7 @@ export class RDMDepositApiClient extends DepositApiClient {
         error.response.data.errors || []
       );
       // this is to serialize raised error from the backend on publish
-      if (errors) errorData = errors;
+      if (!_isEmpty(errors)) errorData = errors;
       throw new DepositApiClientResponse({}, errorData);
     }
   }

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/errors/FormFeedback.js

@@ -211,8 +211,9 @@ class DisconnectedFormFeedback extends Component {
         ? "suggestive"
         : initialFeedback;
 
-    // if no field is specified on the backend, then the message is on the `_schema` field
-    const backendErrorMessage = errors._schema;
+    // if no field is specified on the backend, then the validation message is on the `_schema` field
+    // if the backend returns an explicit message e.g server error, then we use that instead of the default one
+    const backendErrorMessage = errors.message || errors._schema;
 
     // Retrieve the corresponding icon and type if the feedback is a valid key,
     // else fallback to warning.