Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings improvement. #40

Open
MadProbe opened this issue Feb 20, 2022 · 2 comments
Open

Typings improvement. #40

MadProbe opened this issue Feb 20, 2022 · 2 comments

Comments

@MadProbe
Copy link

I want to suggest some improvement on typings:

  1. Mark the length property as readonly since only getter is defined for this property.
  2. I would use optional arguments syntax, e.g. function foo(argument?: whatever) {} instead on consequencial overloads since it's considered as a best practice. (https://github.com/invertase/denque/blob/master/index.d.ts#L4-L8)
@Salakar
Copy link
Member

Salakar commented Feb 21, 2022

We're willing to accept a PR to improve the types if you're interested?

@MadProbe
Copy link
Author

Sure, i'll open a PR in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants