Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: support multiple ios-build-config values #322

Open
1 task done
alestiago opened this issue Jun 26, 2024 · 4 comments
Open
1 task done

request: support multiple ios-build-config values #322

alestiago opened this issue Jun 26, 2024 · 4 comments
Labels
enhancement New feature or request keep open Needs Attention OP created or responded to issue and it needs attention.

Comments

@alestiago
Copy link

alestiago commented Jun 26, 2024

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

flutterfire configure

Description

Currently, if you have more than a single build configuration for your iOs project you are required to run the flutterfire configure command multiple times. From the documentation:

You need to run flutterfire configure for every configuration type. E.g. if you have Debug & Release configurations, you need to run flutterfire configure twice with the relevant arguments documented below.

If you are sharing the same configuration for different iOs build configurations. For example if the project has the following build configurations: Debug-dev, Profile-dev and Release-dev. Then, it would be very convenient to simply run once:

flutterfire configure --project my_project --ios-build-config Debug-dev,Profile-dev,Release-dev --ios-bundle-id com.example.project.dev --ios-out ios/Runner/development --platforms ios

Hence, I would expect the above command to create three identical entries in the firebase.json file, equivalent to when its run multiple times with different ios-build-configs:

{
  "flutter": {
    "platforms": {
      "ios": {
        "buildConfigurations": {
          "Debug-dev": {
            "projectId": "my_project",
            "appId": "1",
            "uploadDebugSymbols": false,
            "fileOutput": "ios/Runner/development/GoogleService-Info.plist"
          },
          "Profile-dev": {
            "projectId": "my_project",
            "appId": "1",
            "uploadDebugSymbols": false,
            "fileOutput": "ios/Runner/development/GoogleService-Info.plist"
          },
          "Release-dev": {
            "projectId": "my_project",
            "appId": "1",
            "uploadDebugSymbols": false,
            "fileOutput": "ios/Runner/development/GoogleService-Info.plist"
          },
        }
      }
    }
  }
}

Reasoning

It is easier to run the command once rather than running it multiple times and changing the --ios-build-config each time with the same configuration.

For example, consider projects that have 3 Schemas (production, release, development) each with 3 Build Configurations (Profile, Debug, Release), a user of the FlutterFire CLI would have to run the command 9 times! Each time modifying the --ios-build-config instead of simply running it 3 times (one per schema, each schema having its own Firebase project configuration).

Additional context and comments

No response

@russellwheatley russellwheatley added enhancement New feature or request and removed triage labels Jul 2, 2024
@Pierre-Monier
Copy link

Can this save us some time ? Or is it going to be only some sugar syntax ?

I hope that it can save us some time, we test an app generation process in a CI environment and the Firebase configuration is the longest part of the generation.

Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@alestiago
Copy link
Author

Commenting to avoid the issue being "stale", @russellwheatley any thoughts or status regarding the issue?

@github-actions github-actions bot added Needs Attention OP created or responded to issue and it needs attention. and removed Stale labels Oct 15, 2024
@russellwheatley
Copy link
Member

Yeah, I like the idea. I've thought about it before. I'll keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep open Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

No branches or pull requests

3 participants