Skip to content

Commit ca1604c

Browse files
committed
chore: refactor workflow and test files
- Remove unnecessary TODO comment in the workflow file - Update test command in workflow to remove unnecessary `|| true` - Update dependency messages matcher in `matchers.dart` test file
1 parent db9ab3c commit ca1604c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/validate.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@ jobs:
9494
- name: Install Tools
9595
run: ./.github/workflows/scripts/install-tools.sh
9696
- name: Run Tests
97-
# TODO: Remove | true once #724 iw solved.
98-
run: melos test --no-select || true
97+
run: melos test --no-select
9998

10099
test_windows:
101100
runs-on: windows-latest

packages/melos/test/matchers.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ Matcher ignoringDependencyMessages(String expected) {
2020
.where(
2121
(line) =>
2222
!line.startsWith('Resolving dependencies...') &&
23-
!line.startsWith('Got dependencies!'),
23+
!line.startsWith('Downloading packages...') &&
24+
!line.startsWith('Got dependencies.'),
2425
)
2526
.join('\n');
2627
return ignoringAnsii(expected).matches(normalizedActual, {});

0 commit comments

Comments
 (0)