ZH4.4.1 ZHC 23.72.1 #2536
Merged
ZH4.4.1 ZHC 23.72.1 #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| src = path.normalize(this.adapter.expandFileName(path.join('img',path.basename(src)))); | ||
| } // img/<filename> relative to data folder | ||
| if (!fs.existsSync(src)) { | ||
| this.warn(`Unable to copy icon from device definition, looked at ${locations.join(', ')} and ${src}`) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
To fix the problem, an explicit semicolon should be added to the end of the this.warn statement on line 156. This change will prevent the possibility of unintended behavior caused by automatic semicolon insertion and align the coding style with the rest of the function.
Suggested changeset
1
lib/statescontroller.js
| @@ -153,7 +153,7 @@ | ||
| src = path.normalize(this.adapter.expandFileName(path.join('img',path.basename(src)))); | ||
| } // img/<filename> relative to data folder | ||
| if (!fs.existsSync(src)) { | ||
| this.warn(`Unable to copy icon from device definition, looked at ${locations.join(', ')} and ${src}`) | ||
| this.warn(`Unable to copy icon from device definition, looked at ${locations.join(', ')} and ${src}`); | ||
| return; | ||
| } | ||
| fs.readFile(src, (err, data) => { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.