Skip to content

Commit 14e907c

Browse files
committed
Loosen up pid argument parsing. Close #41.
1 parent 75bd9ff commit 14e907c

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CHANGELOG.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,15 @@
22
Changelog
33
=========
44

5-
dev
5+
1.7.0 (2021-03-22)
66
------------------
77

8-
* Fixed memory leak via ``sys.last_type``, ``sys.last_value``, ``sys.last_traceback``
8+
* Fixed memory leak via ``sys.last_type``, ``sys.last_value``, ``sys.last_traceback``.
9+
Contributed by Anton Ryzhov in `#59 <https://github.com/ionelmc/python-manhole/pull/59>`_.
10+
* Fixed a bunch of double-close bugs and simplified stream handler code.
11+
Contributed by Anton Ryzhov in `#58 <https://github.com/ionelmc/python-manhole/pull/58>`_.
12+
* Loosen up ``pid`` argument parsing in ``manhole-cli`` to allow using paths with any prefix
13+
(not just ``/tmp``).
914

1015
1.6.0 (2019-01-19)
1116
------------------

src/manhole/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
SIG_NUMBERS.add(num)
2828

2929

30-
def parse_pid(value, regex=re.compile(r'^(/tmp/manhole-)?(?P<pid>\d+)$')):
30+
def parse_pid(value, regex=re.compile(r'^.+(/manhole-)?(?P<pid>\d+)$')):
3131
match = regex.match(value)
3232
if not match:
3333
raise argparse.ArgumentTypeError("PID must be in one of these forms: 1234 or /tmp/manhole-1234")

0 commit comments

Comments
 (0)