Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor options and extend a method to update the map options #25

Open
AE1NS opened this issue Jun 18, 2024 · 0 comments · May be fixed by #26
Open

Refactor options and extend a method to update the map options #25

AE1NS opened this issue Jun 18, 2024 · 0 comments · May be fixed by #26
Labels

Comments

@AE1NS
Copy link

AE1NS commented Jun 18, 2024

Feature Request

Plugin

@capacitor/google-maps

Description

This feature request has 2 topics

Refactor options

  • As styles also exists in google.maps.MapOptions it could be removed from GoogleMapsConfig. I think you added it here, to show it in the documentation, but I would rather write a comment above the class, which properties from google.maps.MapOptions are supported
  • To prevent overhead, the MapType class could be deleted, because its documented in google.maps.MapOptions
  • The following methods could be removed and implemented within the options object (this would require to have a update method, see below):
    • getMapType
    • setMapType
    • enableIndoorMaps
    • enableTrafficLayer
    • enableAccessibilityElements
    • enableCurrentLocation
    • setPadding
  • There should be some additional options in GoogleMapsConfig like:
    • isCompassEnabled
    • isRotateGesturesEnabled
    • isTiltGesturesEnabled
    • isToolbarEnabled
    • isZoomGesturesEnabled
  • Some more properties of google.maps.MapOptions should be handled by the native code like:
    • gestureHandling
    • restriction

Add an update method for map options

The above defined changes should also be appliable by an update method, to change them after the map instantiation.

Platform(s)

Android
iOS
Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant