fix(compiler): handle file rename in watch mode#5968
Closed
tanner-reits wants to merge 2 commits intomainfrom
Closed
fix(compiler): handle file rename in watch mode#5968tanner-reits wants to merge 2 commits intomainfrom
tanner-reits wants to merge 2 commits intomainfrom
Conversation
Fixes: #3443 STENCIL-1104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Fixes: #3443
When renaming a file in watch mode, it is possible to run into two errors:
What is the new behavior?
Addresses both of the issues mentioned above by updating the watched files and compiler context whenever a change is detected that triggers the watch callback
Documentation
N/A
Does this introduce a breaking change?
Testing
This is a difficult issue to test (especially the HMR since that was not always consistent), so I was only able to perform manual tests
Other information