fix(NewClient): support https:// URLs (#277)

lidel · web-flow · commit a32ea331b2d2 · 2025-01-10T21:12:52.000+01:00
* fix(NewClient): support https:// URLs

We don't hardcode any specific ports, but assume `http://`
(backward-compatible behavior)  unless `https://` is passed (then we
keep it as-is).

* chore: v0.14.1

this is backward-compatible fix, ok to just bump patch
diff --git a/http/client.go b/http/client.go
@@ -85,7 +85,8 @@ func ClientWithRawAbsPath(rawAbsPath bool) ClientOpt {
 
 // NewClient constructs a new HTTP-backed command executor.
 func NewClient(address string, opts ...ClientOpt) cmds.Executor {
-	if !strings.HasPrefix(address, "http://") {
+	// default to HTTP to keep backward-compatible behavior, but keep https:// if passed
+	if !strings.HasPrefix(address, "http:") && !strings.HasPrefix(address, "https:") {
 		address = "http://" + address
 	}
 
diff --git a/version.json b/version.json
@@ -1,3 +1,3 @@
 {
-  "version": "v0.14.0"
+  "version": "v0.14.1"
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@ func ClientWithRawAbsPath(rawAbsPath bool) ClientOpt {`
`85`	`85`
`86`	`86`	`// NewClient constructs a new HTTP-backed command executor.`
`87`	`87`	`func NewClient(address string, opts ...ClientOpt) cmds.Executor {`
`88`		`- if !strings.HasPrefix(address, "http://") {`
	`88`	`+ // default to HTTP to keep backward-compatible behavior, but keep https:// if passed`
	`89`	`+ if !strings.HasPrefix(address, "http:") && !strings.HasPrefix(address, "https:") {`
`89`	`90`	`address = "http://" + address`
`90`	`91`	`}`
`91`	`92`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "version": "v0.14.0"`
	`2`	`+ "version": "v0.14.1"`
`3`	`3`	`}`