Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: .url property on response objects #8

Open
SgtPooki opened this issue Mar 3, 2024 · 1 comment
Open

feat: .url property on response objects #8

SgtPooki opened this issue Mar 3, 2024 · 1 comment

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Mar 3, 2024

Created based on mention from @achingbrain at #4 (comment)

After #5 we will have the .url property on responses that is the canonical URL for the requested resource.

With this PR the user can request the same resource via multiple URL formats. Should we be rewriting this URL to turn, for example, subdomain gateway requests into ipfs:// URIs?

I think we should absolutely be setting the canonical URL to the protocol we want to be natively supported in the browsers in the future. Which means, .url should always be a ipfs:// or ipns:// url.

@SgtPooki
Copy link
Member Author

Looking at this again, i think we would be restricted to what gateway-conformance or specs require. I don't think there is any guidance currently on redirects to specific url formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant