docs: Provider.Strategy

explicitly document it is not used - without this legacy users will have
it in their config and be very confused

Author: lidel

cmd/ipfs/kubo/daemon.go

@@ -485,9 +485,8 @@ func daemonFunc(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment
 		// This should never happen, but better safe than sorry
 		log.Fatal("Private network does not work with Routing.Type=auto. Update your config to Routing.Type=dht (or none, and do manual peering)")
 	}
-	if cfg.Provider.Strategy != "" && cfg.Reprovider.Strategy.IsDefault() {
-		// Provider.Strategy isn't used anywhere.
-		log.Fatal("Switch to using Reprovider.Strategy instead of Provider.Strategy. Update your config to remove this message.")
+	if cfg.Provider.Strategy.WithDefault("") != "" && cfg.Reprovider.Strategy.IsDefault() {
+		log.Fatal("Invalid config. Remove unsued Provider.Strategy and set Reprovider.Strategy instead. Documentation: https://github.com/ipfs/kubo/blob/master/docs/config.md#reproviderstrategy")
 	}
 
 	printLibp2pPorts(node)

core/commands/stat_reprovide.go

@@ -24,11 +24,12 @@ var statReprovideCmd = &cmds.Command{
 	Helptext: cmds.HelpText{
 		Tagline: "Returns statistics about the node's reprovider system.",
 		ShortDescription: `
-Returns statistics about the content the node is reproviding every Reprovider.Interval.
+Returns statistics about the content the node is reproviding every
+Reprovider.Interval according to Reprovider.Strategy:
+https://github.com/ipfs/kubo/blob/master/docs/config.md#reprovider
 
 This interface is not stable and may change from release to release.
 
-See https://github.com/ipfs/kubo/blob/master/docs/config.md#reprovider
 `,
 	},
 	Arguments: []cmds.Argument{},

docs/config.md

@@ -106,6 +106,7 @@ config file at runtime.
           - [`Pinning.RemoteServices: Policies.MFS.PinName`](#pinningremoteservices-policiesmfspinname)
           - [`Pinning.RemoteServices: Policies.MFS.RepinInterval`](#pinningremoteservices-policiesmfsrepininterval)
   - [`Provider`](#provider)
+    - [`Provider.Strategy`](#providerstrategy)
     - [`Provider.WorkerCount`](#providerworkercount)
   - [`Pubsub`](#pubsub)
     - [`Pubsub.Enabled`](#pubsubenabled)
@@ -209,6 +210,7 @@ config file at runtime.
     - [`announce-on` profile](#announce-on-profile)
     - [`legacy-cid-v0` profile](#legacy-cid-v0-profile)
     - [`test-cid-v1` profile](#test-cid-v1-profile)
+    - [`test-cid-v1-wide` profile](#test-cid-v1-wide-profile)
   - [Types](#types)
     - [`flag`](#flag)
     - [`priority`](#priority)
@@ -1414,6 +1416,10 @@ commands.
 
 For periodical DHT reprovide settings, see [`Reprovide.*`](#reprovider).
 
+### `Provider.Strategy`
+
+Legacy, not used at the moment, see [`Reprovider.Strategy`](#reproviderstrategy) instead.
+
 ### `Provider.WorkerCount`
 
 Sets the maximum number of _concurrent_ DHT provide operations. DHT reprovides