Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete migration from shark_turbine to iree/turbine namespace #28

Open
ScottTodd opened this issue Jun 10, 2024 · 4 comments
Open

Complete migration from shark_turbine to iree/turbine namespace #28

ScottTodd opened this issue Jun 10, 2024 · 4 comments
Assignees

Comments

@ScottTodd
Copy link
Member

@ScottTodd
Copy link
Member Author

We've had plenty of time to migrate gracefully, but this is going to be a hard blocker for various packaging workflows very soon, so we might need to do a more abrupt cut over instead.

For example:

@stellaraccident
Copy link
Collaborator

Let's do the rename and beef up a couple of tests to ensure that the old namespace still works while we propagate.

Hardcode84 added a commit that referenced this issue Oct 5, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on #28

---------

Signed-off-by: Ivan Butygin <[email protected]>
stellaraccident pushed a commit that referenced this issue Oct 13, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on #28

---------

Signed-off-by: Ivan Butygin <[email protected]>
Hardcode84 added a commit to Hardcode84/iree-turbine that referenced this issue Oct 14, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on iree-org#28

---------

Signed-off-by: Ivan Butygin <[email protected]>
@ScottTodd
Copy link
Member Author

Nice, I see a few commits landed across various repositories. How much is still left to do here, @Hardcode84 ?

@ScottTodd
Copy link
Member Author

ScottTodd added a commit that referenced this issue Oct 17, 2024
saienduri pushed a commit that referenced this issue Oct 28, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on #28

---------

Signed-off-by: Ivan Butygin <[email protected]>
ScottTodd added a commit that referenced this issue Nov 6, 2024
The `docs/releasing.md` file was first introduced next to the
`build_release.py` script in
nod-ai/SHARK-ModelDev#605. I don't see that file
in this repository (iree-org/iree-turbine) though, despite
nod-ai/SHARK-ModelDev#655 claiming that it had
been upstreamed. Since the packages involved have changed over the
months (shark-turbine --> iree-turbine naming, see also
#28), I also updated the
document to reflect the current setup.

The `iree-requirements.txt` file was being used to pin versions of the
`iree-compiler` and `iree-runtime` that would be released together with
this `iree-turbine` package. That was overlooked when
#115 removed pins from that
file. I've reworked the script to reference `iree-requirements-ci.txt`
for now, but we can continue to iterate on the cross-project release
process going forward (with docs this time).

I've updated the version in code from 2.3.0 to 2.5.0. We can push a
release to https://github.com/iree-org/iree-turbine/releases and
https://pypi.org/project/iree-turbine/#history using the new version
next. Note that 2.3.1, 2.4.0, and 2.4.1 were released to PyPI without
updating the code or GitHub releases.
ScottTodd added a commit to iree-org/iree that referenced this issue Nov 7, 2024
This adapts docs and samples to
https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0.

* Switched from `import shark_turbine.aot as aot` to `import
iree.turbine.aot as aot` (see also
iree-org/iree-turbine#28).
* Redirected notes from `/RELEASING.md` to
https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md.
The release process is changing now with
#18938 and I'll want to fold the
notes there in to
https://iree.dev/developers/general/release-management/ instead.
* Re-ran some Colab notebooks and adapted to the latest changes across
projects. Note that the
https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample
still has code using `@aot.jittable`, so I have re-opened
#18564 to migrate it. I spent
some time trying to update it but wasn't sure how to demonstrate dynamic
shapes using the "modern canonical usage" effectively.
* This fixes the recent test failures:
https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934.
Test run:
https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562
JamesMBartlett pushed a commit to gimletlabs/iree that referenced this issue Nov 8, 2024
This adapts docs and samples to
https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0.

* Switched from `import shark_turbine.aot as aot` to `import
iree.turbine.aot as aot` (see also
iree-org/iree-turbine#28).
* Redirected notes from `/RELEASING.md` to
https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md.
The release process is changing now with
iree-org#18938 and I'll want to fold the
notes there in to
https://iree.dev/developers/general/release-management/ instead.
* Re-ran some Colab notebooks and adapted to the latest changes across
projects. Note that the
https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample
still has code using `@aot.jittable`, so I have re-opened
iree-org#18564 to migrate it. I spent
some time trying to update it but wasn't sure how to demonstrate dynamic
shapes using the "modern canonical usage" effectively.
* This fixes the recent test failures:
https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934.
Test run:
https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants