[DO NOT MERGE] try to debug argmax #22394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
requested review from
Groverkss,
MaheshRavishankar and
kuhar
as code owners
bangtianliu
force-pushed
the
bangtian_debug_argmax
branch
5 times, most recently
from
55654f5 to
caf8fa0
Compare
Contributor
Author
|
For this CI error: https://github.com/iree-org/iree/actions/runs/18786121779/job/53605513613?pr=22394#step:7:111 The issue is with this %29:2 = iree_linalg_ext.arg_compare dimension(2) ins(%28 : tensor<4x1x128256xf16>) outs(%11, %12 : tensor<4x1xf16>, tensor<4x1xi32>) {
^bb0(%arg5: f16, %arg6: f16):
%31 = arith.cmpf ogt, %arg5, %arg6 : f16
iree_linalg_ext.yield %31 : i1
} -> tensor<4x1xf16>, tensor<4x1xi32>The root cause is that split reduction is not enabled for the arg_compare operation. |
bangtianliu
force-pushed
the
bangtian_debug_argmax
branch
2 times, most recently
from
d126efd to
d966aea
Compare
bangtianliu
force-pushed
the
bangtian_debug_argmax
branch
4 times, most recently
from
0b1d87d to
40fbc22
Compare
bangtianliu
force-pushed
the
bangtian_debug_argmax
branch
12 times, most recently
from
d998ac6 to
9eb733c
Compare
bangtianliu
force-pushed
the
bangtian_debug_argmax
branch
from
9eb733c to
aac4781
Compare
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
ci-extra: test_torch Signed-off-by: Bangtian Liu <[email protected]> Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of PR #22466, #22490 and #22694 , try to enable O2 for llama 8b fp16 quality tests
ci-extra: test_torch