[Util] Support loop IVs in divisibility analysis #22729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements divisibility inference for affine.apply, affine.min, and affine.max operations through AffineExprDivisibilityFinder visitor. The visitor recursively computes divisibility for affine expressions: - Multiplication: product of operand divisibilities - Addition/Subtraction: GCD (union) of operand divisibilities - Division (floor/ceil): quotient when evenly divisible, else 1 - Modulo: falls back to minimum divisibility (1,1) - Min/Max: GCD of all branch divisibilities Adds TestIntegerDivisibilityAnalysis pass to more directly test divisibility analysis without relying on IR optimizations. The pass probes values with iree_unregistered.test_int_divisibility ops and annotates them with computed divisibility attributes. Also updates arith::DivUIOp divisibility calculation to fallback to minimum divisibility when there is a remainder division, because we can't infer the divisibility when there is a remainder. Signed-off-by: Max Dawkins <[email protected]>
Signed-off-by: Max Dawkins <[email protected]>
Max191
requested review from
MaheshRavishankar,
benvanik,
hanhanW,
jerryyin,
krzysz00 and
nirvedhmeshram
Contributor
Author
|
Based on #22723 to pull in the testing pass (otherwise the PRs are independent), so just review the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for analyzing the induction variables of loop-like ops in the
IntegerDivisibilityAnalysis. This just uses the lower bound and step divisibilities to compute the IV divisibilities based on the simplelb + i * stepexpression.