fix(hip): Correct O(log n) bound search logic and eliminate O(n) loop #22734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `iree_hal_hip_util_tree_lower_bound` and `iree_hal_hip_util_tree_upper_bound` to use the standard O(log n) bound search algorithm. This resolves two issues: 1. **Misbehavior:** Ensures `upper_bound` adheres to the strict 'greater than' definition. 2. **Performance:** Eliminates the previous O(n) post-traversal loop which relied on repeated, inefficient calls to `iree_hal_hip_util_tree_node_next`. fixes : iree-org#22733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
iree_hal_hip_util_tree_lower_boundandiree_hal_hip_util_tree_upper_boundto use the standard O(log n) bound search algorithm.This resolves two issues:
upper_boundadheres to the strict 'greater than' definition.iree_hal_hip_util_tree_node_next.fixes : #22733