Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should check TLS cert validity before sending assertion to the verifier #23

Open
fmarier opened this issue Aug 7, 2013 · 0 comments
Open

Should check TLS cert validity before sending assertion to the verifier #23

fmarier opened this issue Aug 7, 2013 · 0 comments

Comments

@fmarier
Copy link

fmarier commented Aug 7, 2013

As per a comment in the code, the TLS certificate for verifier.login.persona.org should be checked before the output is parsed.

Otherwise, an attacker could mount a DNS poisoning attack and swap the real verifier for their own hostile verifier. This would allow the attacker to impersonate anybody on the site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmarier