Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Firefox release breaks when lots of routes being used and only on Windows 7 #13

Open
javascriptlove opened this issue Nov 21, 2017 · 2 comments

Comments

@javascriptlove
Copy link

With the latest Firefox release (Firefox Quantum) our service stopped working reporting an error of too big call stack. We have a couple hundreds routes, multiplied by 8 languages, resulting in more than 1000 routes. The problem lies in this line calling next() and then it calls next() inside and so on..
https://github.com/iron-meteor/iron-middleware-stack/blob/master/lib/middleware_stack.js#L188

  var next = Meteor.bindEnvironment(function boundNext (err) {

Apparently the call stack is pretty limited on windows 7, and it crashes on client side... I came up with something like this, it works fine at the moment but i'm worried about hidden consequences? #12

@dokithonon
Copy link

I have the same problem with firefox on windows. Did your fix is finally a good solution ? Thanks

@javascriptlove
Copy link
Author

@dokithonon I had to use a forked version as in the pull request #12. Looking that this issue is hanging for 3 years, I'm afraid there's no other way....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants