feat: add model specs

Author: isMattCoding

app/validators/parts_validators.rb

@@ -15,16 +15,20 @@ def validate_each(record, attribute, value)
     unless value.is_a?(String) && value.match(/\A[^0-9]*\z/)
       record.errors.add(:parts, "must be a string and not contain numbers")
     end
-
-    parsed_parts = parse_parts(value)
-    if parsed_parts.empty?
-      record.errors.add(:parts, "contains invalid parts")
+    if value.empty?
+      record.parts = ""
     else
-      record.parts = parsed_parts
+      parsed_parts = parse_parts(value)
+      if parsed_parts[:invalid].length > 0
+        record.errors.add(:parts, "contains invalid parts")
+      else
+        record.parts = parsed_parts[:valid]
+      end
     end
   end
 
   def parse_parts(parts_to_parse)
-    parts_to_parse.split(", ").reject { |part| part.empty? || !POSSIBLE_PARTS.include?(part) }.join(", ")
+    parts = parts_to_parse.split(", ").partition { |part| POSSIBLE_PARTS.include?(part) }
+    { valid: parts[0].join(", "), invalid: parts[1].join(", ") }
   end
 end

spec/requests/bodies_controller_spec.rb

@@ -10,10 +10,6 @@
     valid_attributes_list.map { |attributes| Body.create!(attributes) }
   }
 
-  let(:invalid_attributes) {
-    { parts: "" }
-  }
-
   describe "GET #index" do
     it "returns the created bodies" do
       get :index

spec/requests/bodies_model_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe Body, type: :model do
+  subject { described_class.new(parts: parts) }
+
+  context 'with valid parts' do
+    let(:parts) { 'front-torso, front-thigh-right' }
+
+    it 'is valid' do
+      expect(subject).to be_valid
+    end
+  end
+
+  context 'with invalid parts' do
+    let(:parts) { 'invalid-part, another-invalid-part' }
+
+    it 'is not valid' do
+      puts subject
+      expect(subject).not_to be_valid
+      expect(subject.errors[:parts]).to include("contains invalid parts")
+    end
+  end
+
+  context 'with parts containing numbers' do
+    let(:parts) { 'front-torso1, front-thigh-right' }
+
+    it 'is not valid' do
+      expect(subject).not_to be_valid
+      expect(subject.errors[:parts]).to include("must be a string and not contain numbers")
+    end
+  end
+
+  context 'with parts as a non-string' do
+    let(:parts) { 123 }
+
+    it 'is not valid' do
+      expect(subject).not_to be_valid
+      expect(subject.errors[:parts]).to include("must be a string and not contain numbers")
+    end
+  end
+
+  context 'with a mixture of valid and invalid parts' do
+    let(:parts) { 'front-torso, invalid-part' }
+
+    it 'is not valid' do
+      expect(subject).not_to be_valid
+      expect(subject.errors[:parts]).to include("contains invalid parts")
+    end
+  end
+
+  context 'with empty parts' do
+    let(:parts) { '' }
+
+    it 'is valid' do
+      expect(subject).to be_valid
+    end
+  end
+end

spec/requests/bodies_spec.rb

@@ -8,7 +8,7 @@
   }
 
   let(:invalid_attributes) {
-    { parts: "" }
+    { parts: "invalid-torso, invalid-thigh-right" }
   }
 
   let(:body) { Body.create! valid_attributes }