Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Copy paste mistake in target maker #10

Open
theovincent opened this issue Dec 5, 2021 · 0 comments
Open

Copy paste mistake in target maker #10

theovincent opened this issue Dec 5, 2021 · 0 comments

Comments

@theovincent
Copy link

theovincent commented Dec 5, 2021

It seems like there is a mistake in the target maker.

targets[ns, :len(self.meas_to_predict), :] = ((meas[curr_future_steps][:, self.meas_to_predict] - meas[None,sample][:, self.meas_to_predict])/meas_std[:, self.meas_to_predict]).transpose()

I guess we should substract the mean of the measurements in stead of the value of the measurement in itself.

targets[ns, :len(self.meas_to_predict), :] = ((meas[curr_future_steps][:, self.meas_to_predict] - meas_mean[:, self.meas_to_predict])/meas_std[:, self.meas_to_predict]).transpose() 

@dosovits If what I am saying is true, I would be happy to do a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant