Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a distinction between childFields and innerFields #14

Open
bmv437 opened this issue Feb 10, 2018 · 0 comments
Open

Create a distinction between childFields and innerFields #14

bmv437 opened this issue Feb 10, 2018 · 0 comments

Comments

@bmv437
Copy link
Contributor

bmv437 commented Feb 10, 2018

Are you submitting a bug report or a feature request?

Idea for a new feature

What is the current behavior?

Currently the generator can't tell the difference between childFields and innerFields.

  • Some fields are comprised of multiple innerFields, which is different than the existing parent <-> childFields relationship
  • innerFields are part of the current field, while childFields are not.
  • A shallow validation should validate innerFields and not childFields
  • A deep validation should validate innerFields in addition to childFields
  • We currently use the fields prop in combination with _genChildren to talk about innerFields. An example would be the dateUnknown field.

This comes into play with the new mapFieldChildren() function which was introduced in #13
For validation iterators (ex: isSectionValidIterator()) that are executed with deep: false, it will skip innerFields (which is currently achieved with _genChildren).

Should we support innerFields as first class citizens in the generator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant