feat(a11y): add title to icons

italia · Feb 6, 2025 · 82c4bae · 82c4bae
1 parent 9fa14ee
commit 82c4bae
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/projects/design-angular-kit/src/lib/components/utils/icon/icon.component.html b/projects/design-angular-kit/src/lib/components/utils/icon/icon.component.html
@@ -1,3 +1,6 @@
-<svg [attr.aria-hidden]="isAriaHidden" [attr.aria-label]="labelWaria" [class]="iconClass">
+<svg [attr.role]="role" [attr.aria-hidden]="isAriaHidden" [attr.aria-label]="title || labelWaria" [class]="iconClass">
+  @if (title || labelWaria) {
+    <title>{{ title || labelWaria }}</title>
+  }
   <use [attr.href]="iconHref" [attr.xlink:href]="iconHref"></use>
 </svg>
diff --git a/projects/design-angular-kit/src/lib/components/utils/icon/icon.component.ts b/projects/design-angular-kit/src/lib/components/utils/icon/icon.component.ts
@@ -38,6 +38,16 @@ export class ItIconComponent {
    */
   @Input() svgClass: string | undefined;
 
+  /**
+   * Title of the icon
+   */
+  @Input() title: string | undefined;
+
+  /**
+   * Custom Waria label
+   */
+  @Input() labelWaria: string | undefined;
+
   /**
    * Return the icon href
    */
@@ -71,13 +81,12 @@ export class ItIconComponent {
    */
   protected assetBasePath: string;
 
-  /**
-   * Custom Waria label
-   */
-  @Input() labelWaria: string | undefined;
-
   get isAriaHidden(): boolean {
-    return this.labelWaria == undefined;
+    return this.labelWaria == undefined && this.title == undefined;
+  }
+
+  get role(): string {
+    return this.labelWaria == undefined && this.title == undefined ? undefined : 'img';
   }
 
   constructor() {