Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: video component #1131

Merged
merged 24 commits into from
Mar 19, 2025
Merged

feat: video component #1131

merged 24 commits into from
Mar 19, 2025

Conversation

astagi
Copy link
Member

@astagi astagi commented Nov 28, 2024 •
edited
Loading

Fixes #1101

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Mar 19, 2025 5:31pm

@astagi astagi marked this pull request as draft November 28, 2024 23:41
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.33428% with 20 lines in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (f738af8) to head (9c503f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Video/Video.tsx 90.24% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   97.02%   96.99%   -0.04%     
==========================================
  Files         375      377       +2     
  Lines       27403    27755     +352     
  Branches     1823     1849      +26     
==========================================
+ Hits        26589    26921     +332     
- Misses        807      827      +20     
  Partials        7        7
Flag Coverage Δ
unittests 96.99% <94.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@astagi astagi marked this pull request as ready for review March 18, 2025 08:26
@astagi astagi merged commit f63ad5a into main Mar 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Componente Video player: da fare
2 participants
@astagi @Lorezz