Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab driver branch fetch is using deprecated GitLab CI environment variables #1403

Open
nipierre opened this issue Jul 19, 2023 · 1 comment
Open

GitLab driver branch fetch is using deprecated GitLab CI environment variables #1403

nipierre opened this issue Jul 19, 2023 · 1 comment

Comments

@nipierre
Copy link
Contributor

Summary / Background

The GitLab driver is using a deprecated environment variable to fetch branch name (namely CI_BUILD_REF_NAME).

Scope

Users using CML on GitLab 16.x.

Assumptions

Should be replaced by either CI_COMMIT_REF_NAME or CI_COMMIT_BRANCH.

Open Questions

Blockers / Dependencies

General Approach

In GitLab CI:
cml pr .

Ends up with:

{"level":"error","message":"git,checkout,-B,,c8ea18db3c47a566b6939be8b8c2831dbc5665df\n\t\n\tfatal: '' is not a valid branch name\n","stack":"Error: git,checkout,-B,,c8ea18db3c47a566b6939be8b8c2831dbc5665df\n\t\n\tfatal: '' is not a valid branch name\n\n    at /usr/lib/node_modules/@dvcorg/cml/src/utils.js:38:18\n    at ChildProcess.exithandler (node:child_process:410:5)\n    at ChildProcess.emit (node:events:513:28)\n    at maybeClose (node:internal/child_process:1100:16)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)"}

Timelines

I can push a fix by the end of the week.
@nipierre nipierre added the epic Collection of sub-issues label Jul 19, 2023
@nipierre nipierre changed the title New Feature GitLab driver branch fetch is using deprecated GitLab CI environment variables Jul 19, 2023
@dacbd
Copy link
Contributor

dacbd commented Jul 19, 2023

@nipierre good catch! @ mention me when you create your PR and I'll prioritize getting it merged and released

@dacbd dacbd removed the epic Collection of sub-issues label Jul 19, 2023
nipierre added a commit to nipierre/cml that referenced this issue Jul 20, 2023
@nipierre
fix: replace deprecated gitlab ci var
2cbddb7 
GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME.
In order to be exhaustive, two variables are replacing it:
CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME.

Issue: iterative#1403
@nipierre nipierre mentioned this issue Jul 20, 2023
Merged
dacbd added a commit that referenced this issue Jul 26, 2023
@nipierre @dacbd
fix: replace deprecated gitlab ci var (#1404)
f050c11 
* fix: replace deprecated gitlab ci var

GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME.
In order to be exhaustive, two variables are replacing it:
CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME.

Issue: #1403

* Update src/drivers/gitlab.js

* ci: add expires_at in gitlab credentials

---------

Co-authored-by: Daniel Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dacbd @nipierre