Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: cml comment --publishNative on gitlab ignores large amount of images in stacked markdown spans #1446

Open
miguel7501 opened this issue Apr 18, 2024 · 1 comment

Comments

@miguel7501
Copy link

Description

We currently use cml-publish to let CML add plots of different metrics to our merge requests so we can do a visual check of the training results. Since cml-publish is deprecated, we want to use cml comment create --publishNative instead. At the moment, there are >300 plots. They are arranged in stacked markdown spans so we can keep the irrelevant ones hidden.

cml comment create --publishNative only uploads 49 of the images in the markdown file and its own watermark. The "metric plots" span contains five more spans for different customers that in turn contain multiple plots each. cml comment create --publishNative only properly uploads the plots for the first customer. The other customers just get one plot each with the exception of testcustomerB, who gets 6.

I have attached an anonymized example:
report_before_cml_comment.md
report_after_cml_comment.md

Reproduction

Run report_before_cml_comment.md through a gitlab pipeline using cml comment --publishNative (CML 0.20.0) and have any images in the paths it uses.
Observe it creating a comment with similar content to report_after_cml_comment.md

Expected behaviour

cml comment create --publishNative should upload all images in the markdown file.
If anything prevents it from doing that, it should throw an error instead of failing silently.

@miguel7501 miguel7501 added the epic Collection of sub-issues label Apr 18, 2024
@0x2b3bfa0 0x2b3bfa0 removed the epic Collection of sub-issues label May 10, 2024
@Florian-GitHub
Copy link

are there any updates on this? I have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants