-
Notifications
You must be signed in to change notification settings - Fork 127
Open
Description
Check existing issues
- I checked there isn't already an issue for the bug I encountered.
Describe the bug
If a popup can't open (e.g. blocked by browser due to it not being user activated), we throw an error:
Line 358 in b44c2d4
| if (!popup) throw new Error('Failed to open popup') |
This propagates up to syncRequests, which doesn't handle this error, leaving an unhandled promise promise rejection, which causes the request to hang:
Line 389 in b44c2d4
| if (!popup || popup.closed) this.open() |
Link to Minimal Reproducible Example
No response
Steps To Reproduce
No response
Porto Version
0.0.51
Viem Version
2.30.6
Wagmi Version
2.15.5
TypeScript Version
5.4.2
Anything else?
No response
Copilot
Metadata
Metadata
Assignees
Labels
No labels