lint fixes

Author: itsMapleLeaf

.eslintrc.cjs

@@ -0,0 +1,27 @@
+module.exports = {
+  extends: [require.resolve("@itsmapleleaf/configs/eslint")],
+  plugins: ["prettier"],
+  ignorePatterns: [
+    "**/node_modules/**",
+    "**/dist/**",
+    "**/build/**",
+    "**/.cache/**",
+    "**/.vscode/**",
+    "**/integration/fixtures/**",
+  ],
+  rules: {
+    "prettier/prettier": "error",
+    "import/no-unused-modules": "off",
+    "unicorn/prefer-module": "off",
+    "unicorn/prevent-abbreviations": "off",
+    "unicorn/no-process-exit": "off",
+    "prefer-const": "error",
+    "@typescript-eslint/no-var-requires": "off",
+    "@typescript-eslint/ban-ts-comment": "off",
+  },
+  settings: {
+    react: {
+      version: "detect",
+    },
+  },
+}

package.json

@@ -13,9 +13,9 @@
   ],
   "scripts": {
     "build": "tsup-node src/main.ts --target node16 --format cjs --dts --sourcemap",
-    "build-watch": "pnpm build -- --watch",
+    "build-watch": "pnpm build --watch",
     "lint": "eslint --ext js,ts,tsx .",
-    "lint-fix": "pnpm lint -- --fix",
+    "lint-fix": "pnpm lint --fix",
     "format": "prettier --write .",
     "typecheck": "tsc --noEmit",
     "test": "pnpm build && vitest --no-watch",
@@ -72,35 +72,6 @@
     "vite": "^4.3.9",
     "vitest": "^0.31.2"
   },
-  "eslintConfig": {
-    "extends": [
-      "./node_modules/@itsmapleleaf/configs/eslint"
-    ],
-    "plugins": [
-      "prettier"
-    ],
-    "ignorePatterns": [
-      "**/node_modules/**",
-      "**/dist/**",
-      "**/build/**",
-      "**/.cache/**",
-      "**/.vscode/**",
-      "**/integration/fixtures/**"
-    ],
-    "rules": {
-      "prettier/prettier": "error",
-      "import/no-unused-modules": "off",
-      "unicorn/prefer-module": "off",
-      "unicorn/prevent-abbreviations": "off",
-      "unicorn/no-process-exit": "off",
-      "prefer-const": "error"
-    },
-    "settings": {
-      "react": {
-        "version": "detect"
-      }
-    }
-  },
   "prettier": "@itsmapleleaf/configs/prettier",
   "release-it": {
     "git": {

src/asset-files.ts

@@ -3,7 +3,7 @@ import mime from "mime"
 import { createReadStream } from "node:fs"
 import { readFile } from "node:fs/promises"
 import { relative } from "node:path"
-import { Readable } from "node:stream"
+import { type Readable } from "node:stream"
 
 export type AssetFile = {
   path: string
@@ -19,16 +19,16 @@ export async function collectAssetFiles(folder: string): Promise<AssetFile[]> {
   })
 
   return files.map((file) => ({
-    path: "/" + relative(folder, file).replace(/\\/g, "/"),
+    path: "/" + relative(folder, file).replaceAll("\\", "/"),
     content: () => readFile(file),
     stream: () => createReadStream(file),
   }))
 }
 
-export async function serveAsset(
+export function serveAsset(
   request: Electron.ProtocolRequest,
   files: AssetFile[],
-): Promise<Electron.ProtocolResponse | undefined> {
+): Electron.ProtocolResponse | undefined {
   const url = new URL(request.url)
 
   const file = files.find((file) => file.path === url.pathname)

src/browser-globals.ts

@@ -16,7 +16,9 @@ Object.assign(globalThis, {
   AbortController,
 })
 
-if (typeof globalThis.ReadableStream === "undefined") {
-  const { ReadableStream } = require("@remix-run/web-stream")
+if (globalThis.ReadableStream === undefined) {
+  const { ReadableStream } =
+    // eslint-disable-next-line @typescript-eslint/consistent-type-imports
+    require("@remix-run/web-stream") as typeof import("@remix-run/web-stream")
   globalThis.ReadableStream = ReadableStream
 }

src/main.ts

@@ -47,9 +47,10 @@ export async function initRemix({
   const appRoot = app.getAppPath()
   const publicFolder = asAbsolutePath(publicFolderOption, appRoot)
 
-  let serverBuild: ServerBuild =
+  let serverBuild =
     typeof serverBuildOption === "string"
-      ? require(serverBuildOption)
+      ? // eslint-disable-next-line @typescript-eslint/no-var-requires
+        (require(serverBuildOption) as ServerBuild)
       : serverBuildOption
 
   let [assetFiles] = await Promise.all([
@@ -63,6 +64,7 @@ export async function initRemix({
       ? require.resolve(serverBuildOption)
       : undefined
 
+  // eslint-disable-next-line @typescript-eslint/no-misused-promises
   protocol.interceptStreamProtocol("http", async (request, callback) => {
     try {
       if (mode === "development") {
@@ -81,7 +83,8 @@ export async function initRemix({
         lastBuildTime !== buildTime
       ) {
         purgeRequireCache(buildPath)
-        serverBuild = require(buildPath)
+        // eslint-disable-next-line @typescript-eslint/no-var-requires
+        serverBuild = require(buildPath) as ServerBuild
         lastBuildTime = buildTime
       }
 
@@ -93,10 +96,10 @@ export async function initRemix({
       )
     } catch (error) {
       console.warn("[remix-electron]", error)
+      const { stack, message } = toError(error)
       callback({
         statusCode: 500,
-        // @ts-expect-error
-        data: `<pre>${error?.stack || error?.message || String(error)}</pre>`,
+        data: `<pre>${stack || message}</pre>`,
       })
     }
   })
@@ -113,7 +116,7 @@ async function handleRequest(
   context: unknown,
 ): Promise<Electron.ProtocolResponse> {
   return (
-    (await serveAsset(request, assetFiles)) ??
+    serveAsset(request, assetFiles) ??
     (await serveRemixResponse(request, requestHandler, context))
   )
 }
@@ -125,3 +128,7 @@ function purgeRequireCache(prefix: string) {
     }
   }
 }
+
+function toError(value: unknown) {
+  return value instanceof Error ? value : new Error(String(value))
+}

src/serve-remix-response.ts

@@ -1,8 +1,9 @@
-import type { RequestHandler } from "@remix-run/server-runtime"
-import { Readable, PassThrough } from "node:stream"
+import type { AppLoadContext, RequestHandler } from "@remix-run/server-runtime"
+import { ReadableStream } from "@remix-run/web-stream"
+import { PassThrough, Readable } from "node:stream"
 import "./browser-globals"
 
-function createPassThroughStream(text: any) {
+function createPassThroughStream(text: string | Buffer) {
   const readable = new PassThrough()
   readable.push(text)
   readable.push(null) // eslint-disable-line unicorn/no-null, unicorn/no-array-push-push
@@ -12,7 +13,7 @@ function createPassThroughStream(text: any) {
 export async function serveRemixResponse(
   request: Electron.ProtocolRequest,
   handleRequest: RequestHandler,
-  context: unknown,
+  context: AppLoadContext | undefined,
 ): Promise<Electron.ProtocolResponse> {
   const body = request.uploadData
     ? Buffer.concat(request.uploadData.map((data) => data.bytes))
@@ -37,8 +38,9 @@ export async function serveRemixResponse(
 
   if (response.body instanceof ReadableStream) {
     return {
-      // @ts-expect-error
-      data: Readable.from(response.body),
+      data: Readable.from(
+        response.body as unknown as AsyncIterable<Uint8Array>,
+      ),
       headers,
       statusCode: response.status,
     }

template/app/routes/index.tsx

@@ -8,7 +8,7 @@ export function loader() {
 }
 
 export default function Index() {
-  const data = useLoaderData()
+  const data = useLoaderData<typeof loader>()
   return (
     <main>
       <h1>Welcome to Remix</h1>

tests/fixtures/test-app/app/routes/index.tsx

@@ -1,5 +1,5 @@
-import { useState } from "react"
 import { useLoaderData } from "@remix-run/react"
+import { useState } from "react"
 import { app } from "~/electron.server"
 
 export function loader() {
@@ -9,7 +9,7 @@ export function loader() {
 }
 
 export default function Index() {
-  const data = useLoaderData()
+  const data = useLoaderData<typeof loader>()
   const [count, setCount] = useState(0)
   return (
     <div style={{ fontFamily: "system-ui, sans-serif", lineHeight: "1.4" }}>

tests/fixtures/test-app/app/routes/referrer-redirect.action.tsx

@@ -3,7 +3,7 @@ import { redirect } from "@remix-run/node"
 
 export const action: ActionFunction = async ({ request }) => {
   const { redirects } = Object.fromEntries(await request.formData())
-  const url = new URL(request.headers.get("referer")!)
+  const url = new URL(request.headers.get("referer") as string)
   url.searchParams.set("redirects", String(Number(redirects) + 1))
   return redirect(url.toString())
 }

tsconfig.json

@@ -1,7 +1,7 @@
 {
   "extends": "@itsmapleleaf/configs/tsconfig.base",
   "compilerOptions": {
-    "module": "commonjs",
+    "module": "esnext",
     "noUnusedLocals": true,
     "jsx": "react-jsx",
     "paths": {