Removed the --offline flag in the manage-users command as it was redundant (#687)

Author: Azertinv

README.md

@@ -775,7 +775,6 @@ Usage: mc-image-helper manage-users [-fh] [--existing=<existingFileBehavior>]
                                     >] -t=<type>
                                     [--user-api-provider=<userApiProvider>]
                                     [--version=<version>]
-                                    [--offline]
                                     [[--http-response-timeout=DURATION]
                                     [--tls-handshake-timeout=DURATION]
                                     [--connection-pool-pending-acquire-timeout=D
@@ -814,8 +813,6 @@ Usage: mc-image-helper manage-users [-fh] [--existing=<existingFileBehavior>]
                             Allowed: mojang, playerdb
       --version=<version>   Minecraft game version. If not provided, assumes
                               JSON format
-      --offline             Server is in offline mode, for users that have the
-                              offline flag the UUID is generated locally 
 ```
 
 ### maven-download

src/main/java/me/itzg/helpers/users/ManageUsersCommand.java

@@ -53,9 +53,6 @@ public class ManageUsersCommand implements Callable<Integer> {
     @Option(names = {"--help", "-h"}, usageHelp = true)
     boolean help;
 
-    @Option(names = {"--offline"}, description = "Use for offline server, UUIDs are generated")
-    boolean offline;
-
     @Option(names = "--output-directory", defaultValue = ".")
     Path outputDirectory;
 
@@ -245,7 +242,7 @@ private JavaUser resolveJavaUserId(SharedFetch sharedFetch, List<? extends JavaU
                 }
 
                 // User is not online, generating offline UUID
-                if (offline && user.getFlags().contains("offline")) {
+                if (user.getFlags().contains("offline")) {
                     log.debug("Resolved '{}' as offline user", user.getName());
                     // update UUID keeping the other fields in case of existing user
                     return finalUser.setUuid(getOfflineUUID(user.getName()));

src/test/java/me/itzg/helpers/users/ManageUsersCommandTest.java

@@ -420,7 +420,6 @@ void allOffline(WireMockRuntimeInfo wmInfo) {
                 .execute(
                     "--mojang-api-base-url", wmInfo.getHttpBaseUrl(),
                     "--user-api-provider", "mojang",
-                    "--offline",
                     "--type", "JAVA_WHITELIST",
                     "--output-directory", tempDir.toString(),
                     "user1:offline", "user2:offline"
@@ -456,7 +455,6 @@ void allOnline(WireMockRuntimeInfo wmInfo) {
                 .execute(
                     "--mojang-api-base-url", wmInfo.getHttpBaseUrl(),
                     "--user-api-provider", "mojang",
-                    "--offline",
                     "--type", "JAVA_WHITELIST",
                     "--output-directory", tempDir.toString(),
                     "user1", "user2"
@@ -492,7 +490,6 @@ void partialOnlineOffline(WireMockRuntimeInfo wmInfo) {
                 .execute(
                     "--mojang-api-base-url", wmInfo.getHttpBaseUrl(),
                     "--user-api-provider", "mojang",
-                    "--offline",
                     "--type", "JAVA_WHITELIST",
                     "--output-directory", tempDir.toString(),
                     "user1:offline", "user2"
@@ -538,7 +535,6 @@ void givenNameExistsInCache(WireMockRuntimeInfo wmInfo) throws IOException {
                     "--user-api-provider", "mojang",
                     "--type", "JAVA_WHITELIST",
                     "--output-directory", tempDir.toString(),
-                    "--offline",
                     "user1:offline"
                 );
 
@@ -582,7 +578,6 @@ void changeOnlineToOffline(WireMockRuntimeInfo wmInfo) throws IOException {
                     "--user-api-provider", "mojang",
                     "--type", "JAVA_WHITELIST",
                     "--output-directory", tempDir.toString(),
-                    "--offline",
                     "user1:offline", "user2"
                 );