Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The docs are outdated #686

Open
hotfusion opened this issue Jun 29, 2024 · 0 comments
Open

The docs are outdated #686

hotfusion opened this issue Jun 29, 2024 · 0 comments

Comments

@hotfusion
Copy link

hotfusion commented Jun 29, 2024

Hey,

The example in the documentation may not be compatible with Gulp 5 and the merge2 package. It should be replaced with merge-stream instead. The merge2 package only works with Gulp 4. With Gulp 5, the merge2 package throws the following error Error: Writable stream closed prematurely while running this example:

gulp.task('scripts', function() {
    var tsResult = gulp.src('lib/**/*.ts')
        .pipe(ts({
            declaration: true
        }));
 
    return merge([
        tsResult.dts.pipe(gulp.dest('release/definitions')),
        tsResult.js.pipe(gulp.dest('release/js'))
    ]);
});

This might be confusing for some developers since most of us run npm install gulp, which installs the latest version by default. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant