Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smart-rename rule from wakaru #62

Open
milahu opened this issue Feb 17, 2024 · 2 comments · May be fixed by #63
Open

add smart-rename rule from wakaru #62

milahu opened this issue Feb 17, 2024 · 2 comments · May be fixed by #63
Labels
enhancement New feature or request mangle unminify

Comments

@milahu
Copy link
Contributor

milahu commented Feb 17, 2024

currently, webcrack produces code like

let { sin: k, cos: v, abs: w, log: N, floor: U, PI: A } = Math;

with the smart-rename rule of wakaru this becomes

let { sin, cos, abs, log, floor, PI } = Math;
@milahu milahu added the enhancement New feature or request label Feb 17, 2024
@j4k0xb j4k0xb linked a pull request Feb 17, 2024 that will close this issue
Open
@j4k0xb
Copy link
Owner

j4k0xb commented Feb 17, 2024

done
can you try if it works as expected or find any edge cases? https://deploy-preview-63--webcrack.netlify.app/

@j4k0xb j4k0xb mentioned this issue Aug 2, 2024
Merged
@j4k0xb j4k0xb added mangle and removed unminify labels Aug 16, 2024
@0xdevalias
Copy link
Contributor

0xdevalias commented Mar 11, 2025 •
edited
Loading

done

I haven't deeply contrasted #63 with wakaru's smart-rename implementation, but was curious whether you implemented just the rule mentioned above, or all of it's smart-rename features (eg. the React hooks, etc)

There are also a few current and historic issues relating to other potential smart-rename's:

@j4k0xb j4k0xb marked this as a duplicate of #176 Apr 7, 2025
@j4k0xb j4k0xb added the unminify label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mangle unminify
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename destructuring j4k0xb/webcrack
3 participants
@0xdevalias @milahu @j4k0xb