Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Java 9 new CompletableFuture features in Async #298

Open
billoneil opened this issue Mar 13, 2017 · 1 comment
Open

Document Java 9 new CompletableFuture features in Async #298

billoneil opened this issue Mar 13, 2017 · 1 comment

Comments

@billoneil
Copy link
Contributor

billoneil commented Mar 13, 2017

Looks like Java 9 supports overriding the default executor in CompletableFuture. https://docs.oracle.com/javase/9/docs/api/java/util/concurrent/CompletableFuture.html#defaultExecutor--

This could simplify the implementation of SameExecutorCompletionStage in the future but not until support for java8 is dropped.

Does this kill the need for this class entirely? It would be best to remove it before the release if so. I think it might be nice to have for Java 8 though.

@lukaseder
Copy link
Member

Hmm, interesting discovery, thanks for sharing. I hadn't looked at these Java 9 improvements yet.

I think it's definitely worth mentioning in the Async Javadoc, but these improvements are only valid for CompletableFuture (not CompletionStage), whose design I still don't fully agree with. So I think we can keep the implementation you've added, given that Java 9 will take quite a while to be adopted.

I'll rename this issue to be the task about adding a comment to the Javadoc...

@lukaseder lukaseder added this to the Version 0.9.13 milestone Mar 16, 2017
@lukaseder lukaseder changed the title SameExecutorCompletionStage - Java 9 upgrade Document Java 9 new CompletableFuture features in Async Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants