Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Guzzle or jabranr/php-curl for requests #9

Open
jabranr opened this issue Feb 14, 2017 · 4 comments
Open

Use Guzzle or jabranr/php-curl for requests #9

jabranr opened this issue Feb 14, 2017 · 4 comments

Comments

@jabranr
Copy link
Owner

jabranr commented Feb 14, 2017

Replace internal cURL calls using jabranr/php-curl package. This has to be done with caution as this will introduce a dependency which may not be ideal. On positive side it is great to have this as package has it's own internal unit tests.

@jabranr
Copy link
Owner Author

jabranr commented Feb 14, 2017

Ref: #5

@jabranr
Copy link
Owner Author

jabranr commented Feb 14, 2017

@jamieburchell what would you say about above?

@jabranr jabranr self-assigned this Feb 14, 2017
@jabranr jabranr changed the title Use jabranr/php-curl for requests Use jabranr/php-curl for requests Feb 14, 2017
@jamieburchell
Copy link
Contributor

I would question if it's necessary to build your own cURL wrapper? There are already libraries such as Guzzle that can be used to facilitate sending HTTP messages without relying on cURL even being available.

http://docs.guzzlephp.org/en/latest/

@jabranr
Copy link
Owner Author

jabranr commented May 29, 2017

No doubt. I already had one – jabranr/php-curl – as one of my other side projects so I thought I will keep it in the family 😄 but using Guzzle instead makes more sense!

@jabranr jabranr changed the title Use jabranr/php-curl for requests Use Guzzle or jabranr/php-curl for requests May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants