#730 Upgrade bulma to 1.0.2 #733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use dartsass transpiler because bulma no longer supports the hugo default libsass. Remove semicolon at end of indented lines because of build errors. Signed-off-by: Miroljub Enjakovic <[email protected]>
❌ Deploy Preview for romantic-neumann-1959d7 failed.
|
|
@yurishkuro the build is currently failing because DartSass is not available in the build environment, and it needs to be in order to support Bulma 1.x. This is not something we can circumvent if we want to do the upgrade. |
|
My preference is to have a normal Node module somewhere with a proper package.json and a build command in it. We should not vendor dependencies, but we can commit the generated stylesheets (generated with said build command). This way we don't need Node as part of the regular build process, only when we want to regenerate the stylesheets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #730 - Upgrade bulma to 1.x
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test