Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the tooltip arrow convention. fixes #2221 #2222

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update the tooltip arrow convention. fixes #2221 #2222

wants to merge 6 commits into from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Mar 20, 2024

Which problem is this PR solving?

Description of the changes

  • Replaced all the old conventions for the arrow tooltip center to the new convention.

How was this change tested?

  • yarn test

Checklist

@bupd bupd requested a review from a team as a code owner March 20, 2024 18:52
@bupd bupd requested review from albertteoh and removed request for a team March 20, 2024 18:52
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (f8a4ece) to head (b1973d7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         254      254           
  Lines        7641     7641           
  Branches     1927     1927           
=======================================
  Hits         7381     7381           
  Misses        260      260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

please include before / after screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Tooltip Arrow Configuration in Ant Design Components
2 participants
@bupd @yurishkuro