-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
changelog:new-featureChange that should be called out as new feature in CHANGELOGChange that should be called out as new feature in CHANGELOGenhancementgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement
Description
Requirement
For background see #1051 (comment)
Problem
Even though Storage V2 API supports streaming of the span data from storage, the query service still has to buffer everything in order to apply query-time adjustments (such as clock skew fixes) which require the full trace. This exposes the query service to OOMs if the trace has too many spans.
Proposal
- Add a parameter to query service for the max trace size
- Only load spans from storage up to that amount
- If the load is aborted, add a warning to the returned trace indicating that not all data was loaded
Open questions
No response
Metadata
Metadata
Assignees
Labels
changelog:new-featureChange that should be called out as new feature in CHANGELOGChange that should be called out as new feature in CHANGELOGenhancementgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement