Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-release versions #61

Open
DmitrySamoylov opened this issue Nov 17, 2020 · 0 comments
Open

Support pre-release versions #61

DmitrySamoylov opened this issue Nov 17, 2020 · 0 comments

Comments

@DmitrySamoylov
Copy link

DmitrySamoylov commented Nov 17, 2020

Hey! It looks like the following use case is not supported yet.

Let's say I have such versions in s3 bucket:

  • 0.1.1
  • 0.1.2-beta

And in Cargo.toml I have version = "0.1.2-beta". When trying to perform self-update, I get roughly this output in stdout:

New release found! v0.1.2-beta --> v0.1.2
New release is *NOT* compatible

mybin release status:
  * Current exe: "/usr/bin/mybin"
  * New exe release: "mybin-0.1.2-beta-x86_64-unknown-linux-gnu"
  * New exe download url: "https://<s3>/mybin-0.1.2-beta-x86_64-unknown-linux-gnu"

But expected behaviour is that self_update understands that binary is already up-to-date. Notice this line:

New release found! v0.1.2-beta --> v0.1.2

Obviously it counts mybin-0.1.2-beta-x86_64-unknown-linux-gnu as v0.1.2 and not as v0.1.2-beta. Probably the issue here is that it is hard to tell when pre-release version ends and when triple starts.

Pre-release versions definition: https://semver.org/#spec-item-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant