Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiverse #68

Open
mlohbihler opened this issue Nov 26, 2021 · 0 comments
Open

Support for multiverse #68

mlohbihler opened this issue Nov 26, 2021 · 0 comments

Comments

@mlohbihler
Copy link
Contributor

We are using the multiverse gem to support multiple databases. I've found that the way that the Config's @dbconfig var is created, Squasher cannot start due to errors trying to create connections to the non-default database. Allowing alternate database configurations fixes the problem. For example, at line 125:

          @dbconfig = {
            'development' => content['development'].merge('database' => 'squasher'),
            'timescale_development' => content['timescale_development'].merge('database' => 'squasher'),
          }

(Changing the timescale database to "squasher" is not actually necessary.)

This is fine for allowing Squasher to squash migrations of the default database, but we also would like to squash those of the timescale database too. My thinking is to add two parameters: one to specify all of the configs that need to be part of @dbconfig. The other is to specify the database that is to be squashed. Does this sound reasonable? If so, i could probably create a PR with a proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant