Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger docs inaccurate / outdated #61

Open
8 tasks
kitajchuk opened this issue Sep 2, 2022 · 1 comment
Open
8 tasks

Swagger docs inaccurate / outdated #61

kitajchuk opened this issue Sep 2, 2022 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested

Comments

@kitajchuk
Copy link
Contributor

kitajchuk commented Sep 2, 2022

Something the webapp refresh has illuminated is that the Swagger docs for the API server have quite a bit of inaccuracies compared to actual DTO responses received on the client as well as at least one endpoint missing from the documentation entirely. It would be worth combing over the Swagger yaml and getting the documentation up to date. This issue may overlap with this one: #13 and we might be able to consolidate and close the older issue 🤔.

Todo for this issue:

  • Create a "completed", comprehensive list of what is known to be missing or inaccurate in the Swagger docs

Comprehensive (incomplete) list of what is missing/inaccurate in Swagger docs:

  • The API for Accounts/:account_sid/Applications is in use for the webapp but missing entirely from the docs
  • The SmppGateways/SipGateways show inbound/outbound as boolean but they are actually binary: 1/0
  • The SpeechCredential shows use_for_tts/use_for_stt as boolean but they are also binary: 1/0
  • The RecentCalls shows the field as sip_call_id but it is actually sip_callid as returned from the API
  • The :GET RecentCall and RecentCall pcap toggles have the same ID and both toggle open at the same time
  • The paged responses for CDRs (RecentCalls, Alerts) have a different response schema where the docs claim a field called batch but instead the api returns a page_size field. Also the page and page_size fields are strings whereas the total field is a number and ideally they would all 3 be numbers 🤔
  • ...
@kitajchuk kitajchuk added bug Something isn't working documentation Improvements or additions to documentation question Further information is requested labels Sep 2, 2022
@rjp44
Copy link

rjp44 commented Aug 13, 2023

Please add PhoneNumbers which is at present undocumented to that list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants