Skip to content

Commit 7aba43f

Browse files
authored
Merge pull request #19 from jamesdunham/v0.2.10-cran
v0.2.10
2 parents 645df38 + cf19b8a commit 7aba43f

File tree

8 files changed

+48
-47
lines changed

8 files changed

+48
-47
lines changed

NEWS.md

+14-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1-
# 0.2.9
1+
## 0.2.10
2+
3+
* Remove Rcpp dependency by rewriting `dichotomize()` in R.
4+
* Avoid estimating models (using RStan) during tests, with the goal of rendering
5+
moot variation in build environments. This addresses a test failure during
6+
CRAN's
7+
[r-release-osx-x86_64](https://www.r-project.org/nosvn/R.check/r-release-osx-x86_64/dgo-00check.html)
8+
build.
9+
10+
## 0.2.9
211

312
* Switch from compiling Stan models at install time to compiling them at
413
runtime, avoiding an Rcpp module issue.
@@ -11,7 +20,7 @@
1120
* Argument `by` to `get_n()` and `get_item_n()` methods properly accepts a
1221
vector of variable names when combined with `aggregate` arguments.
1322

14-
# 0.2.8
23+
## 0.2.8
1524

1625
* Improve Stan models for shorter run times
1726
* Add `dgmrp()` for fitting single-issue MRP models with hierarchical covariates
@@ -21,7 +30,7 @@
2130
`dgo_fit` class
2231
* Bugfixes
2332

24-
# 0.2.7
33+
## 0.2.7
2534

2635
* Package renamed dgo: Dynamic Estimation of Group-level Opinion
2736
* Tweaks to pass CRAN checks: clean up examples and docs
@@ -30,12 +39,12 @@
3039
* Fix Rcpp module issue from 0.2.6 (`Error in .doLoadActions(where, attach)`)
3140
* Export `expand_rownames()`
3241

33-
# 0.2.6
42+
## 0.2.6
3443

3544
* Fix error in `dgirt_plot`
3645
* Fix path in `tools/make_cpp.R`
3746

38-
# 0.2.5
47+
## 0.2.5
3948

4049
* `group_names` is no longer required. If omitted, the geographic variable given
4150
by `geo_name` will define groups.

README.Rmd

+20-27
Original file line numberDiff line numberDiff line change
@@ -351,33 +351,26 @@ dgirt_plot(ps, group_names = NULL, time_name = "year", geo_name = "state")
351351
Please [report issues](https://github.com/jamesdunham/dgo/issues) that you
352352
encounter.
353353

354-
OS X only: RStan creates temporary files during estimation in a location given
355-
by `tempdir`, typically an arbitrary location in `/var/folders`. If a model runs
356-
for days, these files can be cleaned up while still needed, which induces an
357-
error. A good solution is to set a safer path for temporary files, using an
358-
environment variable checked at session startup. As described in `?tempdir`,
359-
360-
> The environment variables ‘TMPDIR’, ‘TMP’ and ‘TEMP’ are checked in turn and
361-
> the first found which points to a writable directory is used: if none succeeds
362-
> ‘/tmp’ is used. The path should not contain spaces.
363-
364-
For help setting environment variables, see the Stack Overflow question
365-
[here](https://stackoverflow.com/questions/17107206/change-temporary-directory).
366-
Confirm the new path before starting your model run by restarting R and checking
367-
the output from `tempdir()`.
368-
369-
``` r
370-
# Problematic temporary directories on OS X look like this
371-
tempdir()
372-
#> [1] "/var/folders/2p/_d3c95qd6ljg28j1f5l2jqxm0000gn/T//Rtmp38a10A"
373-
```
374-
375-
Models fitted before October 2016 (specifically <
376-
[#8e6a2cf](https://github.com/jamesdunham/dgo/commit/8e6a2cfbe00b2cd4a908b3067241e06124d143cd))
377-
using dgirtfit are not fully compatible with dgo. Their contents can be
378-
extracted without using dgo, however, with the `$` indexing operator. For
379-
example: `as.data.frame(dgirtfit_object$stan.cmb)`.
380-
354+
* OS X only: RStan creates temporary files during estimation in a location
355+
given by `tempdir`, typically an arbitrary location in `/var/folders`. If a
356+
model runs for days, these files can be cleaned up while still needed, which
357+
induces an error. A good solution is to set a safer path for temporary
358+
files, using an environment variable checked at session startup. For help
359+
setting environment variables, see the Stack Overflow question
360+
[here](https://stackoverflow.com/questions/17107206/change-temporary-directory).
361+
Confirm the new path before starting your model run by restarting R and
362+
checking the output from `tempdir()`.
363+
364+
* Models fitted before October 2016 (specifically <
365+
[#8e6a2cf](https://github.com/jamesdunham/dgo/commit/8e6a2cfbe00b2cd4a908b3067241e06124d143cd))
366+
using dgirtfit are not fully compatible with dgo. Their contents can be
367+
extracted without using dgo, however, with the `$` indexing operator. For
368+
example: `as.data.frame(dgirtfit_object$stan.cmb)`.
369+
370+
* Calling `dgirt()` or `dgmrp()` can generate
371+
[warnings](http://mc-stan.org/misc/warnings#compiler-warnings) during model
372+
compilation. These are safe to ignore, or can be suppressed by following the
373+
linked instructions.
381374

382375
## Contributing and citing
383376

README.md

+3-11
Original file line numberDiff line numberDiff line change
@@ -465,19 +465,11 @@ Troubleshooting
465465

466466
Please [report issues](https://github.com/jamesdunham/dgo/issues) that you encounter.
467467

468-
OS X only: RStan creates temporary files during estimation in a location given by `tempdir`, typically an arbitrary location in `/var/folders`. If a model runs for days, these files can be cleaned up while still needed, which induces an error. A good solution is to set a safer path for temporary files, using an environment variable checked at session startup. As described in `?tempdir`,
468+
- OS X only: RStan creates temporary files during estimation in a location given by `tempdir`, typically an arbitrary location in `/var/folders`. If a model runs for days, these files can be cleaned up while still needed, which induces an error. A good solution is to set a safer path for temporary files, using an environment variable checked at session startup. For help setting environment variables, see the Stack Overflow question [here](https://stackoverflow.com/questions/17107206/change-temporary-directory). Confirm the new path before starting your model run by restarting R and checking the output from `tempdir()`.
469469

470-
> The environment variables ‘TMPDIR’, ‘TMP’ and ‘TEMP’ are checked in turn and the first found which points to a writable directory is used: if none succeeds ‘/tmp’ is used. The path should not contain spaces.
470+
- Models fitted before October 2016 (specifically &lt; [\#8e6a2cf](https://github.com/jamesdunham/dgo/commit/8e6a2cfbe00b2cd4a908b3067241e06124d143cd)) using dgirtfit are not fully compatible with dgo. Their contents can be extracted without using dgo, however, with the `$` indexing operator. For example: `as.data.frame(dgirtfit_object$stan.cmb)`.
471471

472-
For help setting environment variables, see the Stack Overflow question [here](https://stackoverflow.com/questions/17107206/change-temporary-directory). Confirm the new path before starting your model run by restarting R and checking the output from `tempdir()`.
473-
474-
``` r
475-
# Problematic temporary directories on OS X look like this
476-
tempdir()
477-
#> [1] "/var/folders/2p/_d3c95qd6ljg28j1f5l2jqxm0000gn/T//Rtmp38a10A"
478-
```
479-
480-
Models fitted before October 2016 (specifically &lt; [\#8e6a2cf](https://github.com/jamesdunham/dgo/commit/8e6a2cfbe00b2cd4a908b3067241e06124d143cd)) using dgirtfit are not fully compatible with dgo. Their contents can be extracted without using dgo, however, with the `$` indexing operator. For example: `as.data.frame(dgirtfit_object$stan.cmb)`.
472+
- Calling `dgirt()` or `dgmrp()` can generate [warnings](http://mc-stan.org/misc/warnings#compiler-warnings) during model compilation. These are safe to ignore, or can be suppressed by following the linked instructions.
481473

482474
Contributing and citing
483475
-----------------------

cran-comments.md

+11-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
## Test environments
22

33
* local Ubuntu 16.04, R 3.4.0
4-
* Ubuntu 12.04 (on travis-ci), R 3.4.0 (devel and release)
5-
* Windows Server 2012 R2 x64 (on appveyor), R 3.4.0 (devel and release)
4+
* Ubuntu 12.04 (on travis-ci), R 3.4.0 (devel, release) and R 3.3.3
5+
* OS X 10.11 and 10.12 (on travis-ci), R 3.4.0 (devel, release) and R 3.3.3
6+
* Windows Server 2012 R2 x64 (on appveyor), R 3.4.0 (devel and release) and R
7+
3.3.3
68

79

810
## R CMD check results
@@ -11,5 +13,10 @@ There were no ERRORs or WARNINGs.
1113

1214
There was one NOTE:
1315

14-
* "New submission": This is the first submission with this maintainer email.
15-
16+
* "Days since last update: 6": This submission attempts to resolve a build
17+
failure (only) on
18+
[r-release-osx-x86_64](https://www.r-project.org/nosvn/R.check/r-release-osx-x86_64/dgo-00check.html)
19+
resulting from a failing test, which does not occur on travis-ci. This
20+
submission avoids using dependency RStan during tests and removes a dependency
21+
on Rcpp. The goal of these changes is to render moot variation in build
22+
environments.

data/toy_dgirt_in.rda

-32 Bytes
Binary file not shown.

data/toy_dgirtfit.rda

638 Bytes
Binary file not shown.

tests/testthat/dgirt_ret.Rds

-215 Bytes
Binary file not shown.

tests/testthat/dgmrp_ret.Rds

-238 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)