-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration of a down event in the succeeded email notification #935
Comments
This used to be included until I broke the code :) but I do remember I was working on fixing it... I must have a branch somewhere with the changes on so I'll see about finishing it and merging it! |
Ha! I recently updated my server (including simplemonitor) and I see that preivously:
I had thought that I had seen it and then I thought that perhaps it was another monitoring system that I use :) |
I had a look and the code is already merged to the develop branch but not yet in a proper release. |
Thanks! - do you have a favourite way to use the develop branch? I've tried quickly with Otherwise I will try to try again in the evening... |
That should work. Make sure you're on a recent pip, and you (on recent pips) need to change the URL to git+https (or similar), but I just tested in a fresh venv and this worked ok:
That's with Python 3.9.4 and pip 22.0.4 (which I upgraded inside the venv before installing simplemonitor; the supplied one was 20.x, and fails to install the cryptography package). |
Confirmed, with pip 22.0.4 and the the pip install that you shared it's up and running. I will comment if you want when I see a down/up email with the duration :-) |
Yay! I've spotted a small bug and will push a fix to develop shortly: it's formatting the timestamp incorrectly (I got one which was 0+0:00:60 instead of 0+0:01:00) |
In the succeeded email notification I receive:
Feature request: to write how long it was down.
The text was updated successfully, but these errors were encountered: