-
Notifications
You must be signed in to change notification settings - Fork 0
Commit a06a55c
Bug 1952549 [wpt PR 51199] - Revert "Fix bug where cc clip paths affected intersection behavior", a=testonly
Automatic update from web-platform-tests
Revert "Fix bug where cc clip paths affected intersection behavior"
This reverts commit a3e653cb68ffa703751f81c1756de5dc30ae82c2.
Reason for revert: breaking devtools-frontend e2e tests with a regression on hit testing area not reflecting the rendered area (see the screencast (M134 vs M136): https://imgur.com/a/2RUfN3B
Repro in: https://codepen.io/ergunsh/pen/zxYzEem
See the comments in devtools-frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6331110?tab=comments
Original change's description:
> Fix bug where cc clip paths affected intersection behavior
>
> This change fixes a bug where intersection observers would behave
> differently depending on whether the feature is enabled or not. This
> bug occurred because ClipPathClipper::LocalClipPathBoundingBox is
> used both for painting and for computing intersections. This change
> reverts ClipPathClipper::LocalClipPathBoundingBox back to its prior
> behavior, and instead explicitly overrides usages when a cc clip path
> animation is present.
>
> Additionally, this change adds an extra flag to the clip paint
> property so that it is dectectable in code whether there is a cc
> clip path animation requiring an expanded rectangle. This allows
> intersection observers to query the real 'precise' rectangle when
> necessary, by means of a special flag.
>
> A test is added for this case.
>
> Bug: 394244260
>
> Change-Id: I22024a0264366b055416eebefb91ffec8861e998
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6242433
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Claire Chambers <[email protected]>
> Reviewed-by: Philip Rogers <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1427364}
Bug: 394244260
Change-Id: I791e7211e5fb70624303e84ead32c1545e13bd42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330165
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1429614}
--
wpt-commits: 1987fdaadb1afabd5d430f500a0e9200e8d933ac
wpt-pr: 511991 parent b4d66c7 commit a06a55cCopy full SHA for a06a55c
File tree
1 file changed
+0
-99
lines changedFilter options
- testing/web-platform/tests/intersection-observer
1 file changed
+0
-99
lines changedtesting/web-platform/tests/intersection-observer/clip-path-animation.html
Copy file name to clipboardExpand all lines: testing/web-platform/tests/intersection-observer/clip-path-animation.html-99
This file was deleted.
0 commit comments