Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary permissions on iOS when using on-device recognition #56

Open
msschwartz opened this issue Nov 17, 2024 · 1 comment
Open

Comments

@msschwartz
Copy link
Contributor

msschwartz commented Nov 17, 2024

If user is using the on-device recognition, we do not need to prompt the user for speech recognition permission.

Speech data from this app will be sent to Apple to process your requests. This will also help Apple improve its speech recognition technology.

This can be a show stopper on apps with sensitive data that users prefer to keep private.

A quick proof-of-concept PR has been created to show how this can be improved to separate the microphone permissions from speech recognizer permissions. #55

@jamsch
Copy link
Owner

jamsch commented Nov 17, 2024

Thank you @msschwartz! Yep, I overlooked this and we definitely need more granular permissions here in cases like this, as well as for troubleshooting permissions issues. I'll be able to review your PR later today but my initial impressions are:

  • Implement requestMicrophonePermissionsAsync() to request RECORD_AUDIO permissions for Android and (maybe) suffix the method name for requestSpeechRecognizerPermissionsAsync() with IOS (if no other platform has an equivalent permission).
  • Probably still keep the requestPermissionsAsync API around without the deprecation marker just so that it's the easy path for most (as Android only needs one permission).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants