-
Notifications
You must be signed in to change notification settings - Fork 233
Description
Describe the bug
Issue #2492 reported a lag when many Gain change messages were generated, e.g. by a MIDI controller. This was fixed in #2535 by using a rate-limiting timer.
I have now observed exactly the same behaviour with Pan change messages, which is not surprising, although not mentioned in the issue above nor addressed in the PR. Adjustments to Pan are much less frequent in practice, which is probably why it has never been reported.
To Reproduce
Start Jamulus with a MIDI controller such as Korg NanoKontrol2, connect to a distant server, and move the Pan control for a channel by a large amount. See #2492 for more details of the testing that was done for faders, including packet tracing.
Expected behavior
Pan change messages need to be rate-limited in the same way as Gain-change messages.
Screenshots
Operating system
Any. Testing was done on Raspberry Pi.
Version of Jamulus
All versions up to 3.11.0 inclusive.
Additional context
Metadata
Metadata
Assignees
Labels
Type
Projects
Status