-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Rectangle shape #2
Comments
I have a working solution for this enhancement, which I could provide if desired. I extended the functionality of the ng2-img-map class that it can distinguish circles (marker with two numbers) and rectangles (mark with four numbers: x, y , width, height). Problem with with approach is that it feels inconsistent if one uses only rectangles, but can set the markerRadius, which won't have any effect. Possible solution here would be to move the radius to the markers array (x,y, radius), which would also allow cirlces with different radii/radiuses |
Hey @Akkusativobjekt have you updated the module to accept rectangles? Thanks |
I have this implemented in the version I forked, along with polygons, image-icons, and drag-support for the aforementioned components. I will comment, clean-up the code and make a pull-request soon. |
Hey @kunmi how do I get access to your updated version? I need to be able to draw polygons. Thanks! |
@MattWlodarski Quick notes (included in the branch feature_polygon)
This was also my first and last foray into angular, I tried adhering as much as possible to the design patterns; sorry if I in some ways; I might have disobeyed some patterns. I HOPE ITS HELPFUL 👍 |
Hey @kunmi are rectangles available now? |
Hey devs,
How do I draw a rectangle with this module. Default one seems to draw only circle.
Help will be highly appreciated.
The text was updated successfully, but these errors were encountered: