Skip to content

HP dice roller bug #496

@LHoyle

Description

@LHoyle

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

expanded a bit too far here, It only really needs the (2d8) but I'd like to be able to have both features here (adverage is still wrong, it should show as [3.5,3.5] based on other documentation)
Image

Current behaviour

in the HP section, the average isn't right and it isn't showing parentheses notation
Image

The reset dice is also not working.

Reproduction

Launch obsidian.
load/make stat block
view in non-code block form.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.8.10

Plugin Version

4.9.1

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

This is caused by lines:
src/main.ts
Lines 222 and 233 contain
showFormula: false,
showParens: false,

Then again in
src/settings/settings.ts you get the same code

I was able to get a band-aid solution with a find/replace showFormula:!0,showParens:!0, as shown in the compiled version for the fix above

I think its a simple a change to
showParens:this.plugin.settings.showParens
then and add a corresponding setting. If I get time to I'll see if I can get this working. extra goal would be to just look at the settings for the dice roller itself, but thats neither here nor there. No clue for the reset one

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions