Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding properties for Maven plugin through properties configuration #763

Open
beikov opened this issue Aug 28, 2022 · 2 comments · May be fixed by #764
Open

Allow overriding properties for Maven plugin through properties configuration #763

beikov opened this issue Aug 28, 2022 · 2 comments · May be fixed by #764

Comments

@beikov
Copy link

beikov commented Aug 28, 2022

jbake.properties should be overridable through the configuration section of the maven plugin. Also see jbake-org/jbake-maven-plugin#44
beikov added a commit to beikov/jbake that referenced this issue Aug 28, 2022
@beikov
[jbake-org#763] Allow overriding jbake.properties through maven plugin
f98d8fc
@beikov beikov linked a pull request Aug 28, 2022 that will close this issue
Open
@kwin
Copy link
Contributor

kwin commented Sep 9, 2022

Isn't this a duplicate of #717?

@beikov
Copy link
Author

beikov commented Sep 9, 2022

Seems somewhat similar, though the approach is different. I change how the plugin works and you change the core parts. Not sure which is better or more desirable, but if the end result is the same, I'm fine with either approach.
It seems like @jonbullock doesn't maintain the project anymore though, so not sure how JBake can progress now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#763] Allow overriding jbake.properties through maven plugin beikov/jbake
2 participants
@kwin @beikov