Skip to content

Commit 7359aa7

Browse files
authored
fix: a11y issues (#68)
* fix: add aria-label to mode toggle btn * fix: make links underlined at all times * fix: button/img alt text * fix: link styling
1 parent 68fe7bf commit 7359aa7

File tree

6 files changed

+15
-11
lines changed

6 files changed

+15
-11
lines changed

src/components/CertificatesBar.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,25 @@ export const CertificatesBar: React.FC = () => {
1212
href="https://www.credly.com/badges/517ae2cf-990f-4e3f-acf7-c7dc692c67a0/public_url"
1313
tooltip="AWS Certified Developer (DVA-C01)"
1414
>
15-
<FaAws className="w-6 h-6 hover:text-[#ff9900]" />
15+
<FaAws aria-label="AWS Certified Developer (DVA-C01) certificate" className="w-6 h-6 hover:text-[#ff9900]" />
1616
</IconButton>
1717
<IconButton
1818
href="https://www.credly.com/badges/e6715f11-b3a5-4793-ad15-569250ac42f6/public_url"
1919
tooltip="Datadog Fundamentals"
2020
>
21-
<SiDatadog className="w-6 h-6 hover:text-[#632ca6]" />
21+
<SiDatadog aria-label="Datadog Fundamentals certificate" className="w-6 h-6 hover:text-[#632ca6]" />
2222
</IconButton>
2323
<IconButton
2424
href="https://www.credly.com/badges/646b9426-2046-459d-a0cf-f2c3fd8c6fa1/public_url"
2525
tooltip="PagerDuty Incident Responder"
2626
>
27-
<SiPagerduty className="w-6 h-6 hover:text-[#048a24]" />
27+
<SiPagerduty aria-label="PagerDuty Incident Responder certificate" className="w-6 h-6 hover:text-[#048a24]" />
2828
</IconButton>
2929
<IconButton
3030
href="https://credentials.getdbt.com/0eda8bc8-abda-43ca-80ae-10ffb87fcfd2"
3131
tooltip="dbt Fundamentals"
3232
>
33-
<SiDbt className="w-6 h-6 hover:text-[#ff6849]" />
33+
<SiDbt aria-label="dbt Fundamentals Certificate" className="w-6 h-6 hover:text-[#ff6849]" />
3434
</IconButton>
3535
</TooltipProvider>
3636
</div>

src/components/ContinueIndicator.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const ContinueIndicator: React.FC<ContinueIndicatorProps> = ({
1414
<div className={className}>
1515
<Button variant="ghost" onClick={() => scrollToSection(nextSection)}>
1616
<ChevronDown
17+
aria-label="Continue to next section"
1718
className="w-8 h-8 animate-bounce hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]"
1819
onClick={() => scrollToSection("about")}
1920
/>

src/components/Link.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const Link = ({ href, children, className }: LinkProps) => (
1717
target="_blank"
1818
href={href}
1919
className={cn(
20-
"hover:text-[#1ca7d0] dark:hover:text-[#90cdf4] hover:underline",
20+
"hover:text-[#1ca7d0] dark:hover:text-[#90cdf4] underline",
2121
className,
2222
)}
2323
rel="noreferrer"
@@ -30,7 +30,7 @@ export const StyledLink = ({ href, children, className }: LinkProps) => (
3030
<a
3131
target="_blank"
3232
href={href}
33-
className={cn("text-[#1ca7d0] hover:underline", className)}
33+
className={cn("text-[#1ca7d0] underline", className)}
3434
rel="noreferrer"
3535
>
3636
{children}

src/components/SocialsBar.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,21 @@ const socials: Social[] = [
1212
{
1313
label: "Github",
1414
icon: (
15-
<Github className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
15+
<Github aria-label="Github Profile" className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
1616
),
1717
url: "https://github.com/jcserv",
1818
},
1919
{
2020
label: "LinkedIn",
2121
icon: (
22-
<Linkedin className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
22+
<Linkedin aria-label="LinkedIn Profile" className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
2323
),
2424
url: "https://linkedin.com/in/jarrod-servilla",
2525
},
2626
{
2727
label: "Resume",
2828
icon: (
29-
<File className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
29+
<File aria-label="Jarrod Servilla's Resume" className="w-6 h-6 hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />
3030
),
3131
url: "/resume.pdf",
3232
},

src/components/mode-toggle.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export function ModeToggle() {
1111
};
1212

1313
return (
14-
<Button variant="ghost" onClick={toggleDarkMode} className="p-2 w-8 h-8">
14+
<Button variant="ghost" aria-label={`Set theme to ${theme === "dark" ? 'light mode' : 'dark mode'}` } onClick={toggleDarkMode} className="p-2 w-8 h-8">
1515
{theme === "dark" ? (
1616
<Moon className="w-4 h-4" />
1717
) : (

src/sections/Projects/Projects.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,24 +18,27 @@ const linkIcons: Map<LinkType, JSX.Element> = new Map([
1818
"github",
1919
<Github
2020
key="github"
21+
aria-label="Github Repository"
2122
className="hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]"
2223
/>,
2324
],
2425
[
2526
"youtube",
2627
<Youtube
2728
key="youtube"
29+
aria-label="YouTube Demo"
2830
className="hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]"
2931
/>,
3032
],
3133
[
3234
"devpost",
3335
<SiDevpost
3436
key="devpost"
37+
aria-label="Devpost Project Page"
3538
className="hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]"
3639
/>,
3740
],
38-
["link", <Link key="link" />],
41+
["link", <Link key="link" aria-label="Link to Project" className="hover:text-[#1ca7d0] dark:hover:text-[#90cdf4]" />],
3942
]);
4043

4144
type ProjectLink = {

0 commit comments

Comments
 (0)