select generation is bad

[Maujard]

core/desktop/php/widgets.php

Line 173 in 90a95f1

foreach ((widgets::listTemplate()) as $type => $values) {

<option value="" data-default="1"><a></option>

is not supported.
modify by 'selected' on the first option

<option data-type="info" value="numeric" selected>Numérique</option>

the code generate is :

 <select id="sel_widgetSubtype">
     <option value="" data-default="1"><a></option>
     <option data-type="info" value="numeric"><a>Numérique</option>
     <option data-type="info" value="binary"><a>Binaire</option>
     <option data-type="info" value="string"><a>Autre</option>
     <option data-type="action" value="other"><a>Défaut</option>
     <option data-type="action" value="slider"><a>Curseur</option>
     <option data-type="action" value="message"><a>Message</option>
     <option data-type="action" value="color"><a>Couleur</option>
     <option data-type="action" value="select"><a>Liste</option>
     </select>

and must be :

<div class="col-xs-8">
   <select id="sel_widgetSubtype" class="form-control">
   <option data-type="info" value="numeric" selected>Numérique</option>
   <option data-type="info" value="binary">Binaire</option>
   <option data-type="info" value="string">Autre</option>
   <option data-type="action" value="other">Défaut</option>
   <option data-type="action" value="slider">Curseur</option>
   <option data-type="action" value="message">Message</option>
   <option data-type="action" value="color">Couleur</option>
   <option data-type="action" value="select">Liste</option>
   </select>

[Maujard]

the good syntax perhaps must be

<?php
foreach ((widgets::listTemplate()) as $type => $values) {
    foreach ($values as $subtype => $namelist) {
        $first = true; // Indicateur pour la première option
        foreach ($namelist as $name) {
            $selected = $first ? ' selected' : ''; // Ajoute selected uniquement pour le premier élément
            echo '<option data-type="' . $type . '" data-subtype="' . $subtype . '" value="' . $name . '"' . $selected . '>' . ucfirst(str_replace('tmpl', '', $name)) . '</option>';
            $first = false; // Désactive l'indicateur après la première itération
        }
    }
}
?> 

[Maujard]

I think is dreadful when you try to create a widget directly 👍

<div class="form-group">
    <label class="col-lg-4 col-xs-4 control-label">Sous-Type</label>
    <div class="col-lg-4 col-xs-5">
        <select class="form-control selectWidgetSubType"
            data-l1key="subtype" data-type="info">
            <option data-type="info" value="numeric"><a>Numérique</option>
            <option data-type="info" value="binary"><a>Binaire</option>
            <option data-type="info" value="string"><a>Autre</option>
        </select><select class="form-control selectWidgetSubType"
            data-l1key="subtype" data-type="action">
            <option data-type="action" value="other"><a>Défaut</option>
            <option data-type="action" value="slider"><a>Curseur</option>
            <option data-type="action" value="message"><a>Message</option>
            <option data-type="action" value="color"><a>Couleur</option>
            <option data-type="action" value="select"><a>Liste</option>
        </select>
    </div>

[zoic21]

Hello,
Thank for your return, I create a PR with correction #3044